Re: pg_combinebackup does not detect missing files

On Fri, Aug 2, 2024 at 7:07 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Fri, Apr 19, 2024 at 11:47 AM Robert Haas <robertmhaas@gmail.com> wrote:
> >
> [...]
> Here is a rebased version of the patch. No other changes since v1.
>

Here are two minor comments on this:

$ pg_combinebackup  /tmp/backup_full/ /tmp/backup_incr2/
/tmp/backup_incr3/ -o /tmp/backup_comb
pg_combinebackup: warning: "pg_wal/000000010000000000000020" is
present on disk but not in the manifest

This warning shouldn’t be reported, since we don’t include WAL in the
backup manifest ? Also, I found that the final resultant manifest
includes this WAL entry:

$ head /tmp/backup_comb/backup_manifest | grep pg_wal
{ "Path": "pg_wal/000000010000000000000020", "Size": 16777216,
"Last-Modified": "2024-08-06 11:54:16 GMT" },

---

+# Set up another new database instance.  force_initdb is used because
+# we want it to be a separate cluster with a different system ID.
+my $node2 = PostgreSQL::Test::Cluster->new('node2');
+$node2->init(force_initdb => 1, has_archiving => 1, allows_streaming => 1);
+$node2->append_conf('postgresql.conf', 'summarize_wal = on');
+$node2->start;
+

Unused cluster-node in the test.

Regards,
Amul