Re: Some leftovers of recent message cleanup?

On 2021/08/20 11:53, Kyotaro Horiguchi wrote:
> At Thu, 19 Aug 2021 20:29:42 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>> On 2021/08/19 17:03, Kyotaro Horiguchi wrote:
>>> Hello.
>>> While I was examining message translation for PG14, I found some
>>> messages that would need to be fixed.
>>> 0001 is a fix for perhaps-leftovers of the recent message cleanups
>>> related to "positive integer"(fd90f6ba7a).
>>
>> There are still other many messages using "positive" and "negative"
>> keywords.
>> We should also fix them at all?
> 
> I'm not sure, or no if anything. My main point here is not to avoid
> use of such kind of words, but reducing variations of the effectively
> the same message from the view of translator burden. The two messages
> in 0001 are in that category. I noticed those messages accidentally. I
> don't think they are the only instance of such divergence, but I'm not
> going to do a comprehensive examination of such divergences.. (Or do I
> need to check that more comprehensively?)


Understood.

-                     errmsg("modulus for hash partition must be a positive integer")));
+                     errmsg("modulus for hash partition must be an integer greater than zero")));

"an integer greater" should be "an integer value greater" because
we use that words in other similar log messages like "modulus for
hash partition must be an integer value greater than zero"
in src/backend/partitioning/partbounds.c?

I'm thinking to back-patch this to v11 where hash partitioning
was supported. On the other hand, the following change should
be back-patched to all supported versions.

-                             errmsg("distance in phrase operator should not be greater than %d",
+                             errmsg("distance in phrase operator must be an integer value between zero and %d
inclusive",

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION