Re: Buffer statistics for pg_stat_statements
От
Robert Haas
Тема
Re: Buffer statistics for pg_stat_statements
Дата
Msg-id
603c8f071001070733r42d10899xbb26339a7bb55b20@mail.gmail.com
Ответ на
Re: Buffer statistics for pg_stat_statements (Takahiro Itagaki)
Список
Дерево обсуждения
Buffer statistics for pg_stat_statements Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Re: Buffer statistics for pg_stat_statements Cédric Villemain <cedric.villemain@dalibo.com>
Re: Buffer statistics for pg_stat_statements Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Re: Buffer statistics for pg_stat_statements Robert Haas <robertmhaas@gmail.com>
Re: Buffer statistics for pg_stat_statements Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Re: Buffer statistics for pg_stat_statements Robert Haas <robertmhaas@gmail.com>
Re: Buffer statistics for pg_stat_statements Tom Lane <tgl@sss.pgh.pa.us>
Re: Buffer statistics for pg_stat_statements Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Re: Buffer statistics for pg_stat_statements Robert Haas <robertmhaas@gmail.com>
Re: Buffer statistics for pg_stat_statements Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Re: Buffer statistics for pg_stat_statements Cédric Villemain <cedric.villemain.debian@gmail.com>
On Thu, Jan 7, 2010 at 3:31 AM, Takahiro Itagaki wrote: > > Tom Lane wrote: > >> > I don't necessarily know what the right thing to do with the new ones >> > is, but I am pretty sure that pg_indent will revert any changes you >> > make to the existing ones. >> >> That it will. The proposed changes to the existing lines are an >> exercise in uselessness; and to the extent that you format the added >> lines with this layout in mind, the final result could be worse than >> what you'd get if you adapt to pg_indent's rules to start with. > > Here is the proposed patch to adjust white spaces. > It does not indent variables, but indents comments of the variables > to adjust other fields. Are those changes ok? I think so. I'm not sure if it will push out the comment that is immediately adjacent to the trailing semicolon, but I don't think it will decrease the indent on the ones you've indented more. I think this is close enough for now and you should go ahead and commit it. ...Robert
В списке pgsql-hackers по дате отправления