Re: type cache cleanup improvements
От
Andrei Lepikhov
Тема
Re: type cache cleanup improvements
Дата
Msg-id
3b6d9bcf-5b48-4210-921b-4641c74e1b39@gmail.com
Список
Дерево обсуждения
type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Tom Lane <tgl@sss.pgh.pa.us>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Aleksander Alekseev <aleksander@timescale.com>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Michael Paquier <michael@paquier.xyz>
Re: type cache cleanup improvements Teodor Sigaev <teodor@sigaev.ru>
Re: type cache cleanup improvements Жарков Роман <r.zharkov@postgrespro.ru>
Re: type cache cleanup improvements Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Re: type cache cleanup improvements Alexander Korotkov <aekorotkov@gmail.com>
On 21/10/2024 00:36, Alexander Korotkov wrote: > On Thu, Oct 17, 2024 at 12:41 PM Andrei Lepikhov wrote: >> I think the first patch may already be committed, and this little burden >> may be avoided in future versions. > I've integrated your patch. But I think > finalize_in_progress_typentries() is more appropriate place to check > typentry for NULL. Also, I've revised the > finalize_in_progress_typentries() header comment. I'm going to push > these patches if no objections. I agree with your idea. Also, I think it would be more conventional not to check the type entry for a NULL value but to test the 'found' value instead. And thanks for the injection points tests! I must have slipped my mind about this option. Now, the patch set looks good for me. -- regards, Andrei Lepikhov
В списке pgsql-hackers по дате отправления