Re: Minor pg_amcheck fixes spotted while reading code

Поиск
Список
Период
Сортировка
Искать
От
Mark Dilger
Тема
Re: Minor pg_amcheck fixes spotted while reading code
Дата
Msg-id
3A6DD139-43F8-455D-BEE7-4D1CD0C013D3@enterprisedb.com
Ответ на
Список
Дерево обсуждения
Minor pg_amcheck fixes spotted while reading code Daniel Gustafsson <daniel@yesql.se>
Re: Minor pg_amcheck fixes spotted while reading code Mark Dilger <mark.dilger@enterprisedb.com>
Re: Minor pg_amcheck fixes spotted while reading code Michael Paquier <michael@paquier.xyz>
Re: Minor pg_amcheck fixes spotted while reading code Daniel Gustafsson <daniel@yesql.se>


> On Aug 20, 2021, at 11:19 AM, Daniel Gustafsson  wrote:
> 
> When perusing the pg_amcheck code the other day for the recently pushed fixes I
> found two small things that seem worth fixing: The help function progname
> parameter shadows the global variable of the same name, which no doubt will
> make static analyzers complain so we might as well fix that; and there is a
> tiny typo in the test stanza.
> 
> Both fixed in the attached.
> 
> --
> Daniel Gustafsson		https://vmware.com/
> 
> <0001-Fix-variable-shadowing.patch><0002-pg_amcheck-test-typofix.patch>

These look correct.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





В списке pgsql-hackers по дате отправления
От: Robert Haas
Дата:
От: Robert Haas
Дата:
FAQ