Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Дата
Msg-id
344325.1755524074@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Compilation issues for HASH_STATISTICS and HASH_DEBUG options "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
RE: Compilation issues for HASH_STATISTICS and HASH_DEBUG options "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
RE: Compilation issues for HASH_STATISTICS and HASH_DEBUG options "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Michael Paquier <michael@paquier.xyz>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options Tom Lane <tgl@sss.pgh.pa.us>
Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options David Rowley <dgrowleyml@gmail.com>
David Rowley  writes:
> I've purposefully left references to HASH_DEBUG in the "Original
> comments" section near the top of dynahash.c. That comment also
> references function names that no longer exist.

Hm, there is actually no part of that comment para that is accurate
anymore, so I cannot imagine a reason for leaving it alone.  People
who want to do archaeology can consult the git history.  How about
reducing the para to

 * HASH_STATISTICS causes some usage statistics to be maintained,
 * which can be logged by calling hash_stats().

LGTM otherwise.

			regards, tom lane


В списке pgsql-hackers по дате отправления
От: torikoshia
Дата:
От: Dominique Devienne
Дата:
FAQ