Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
От
Dmitry Koval
Тема
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Дата
Msg-id
30c76d19-3c45-b714-d815-15fce519c749@postgrespro.ru
Ответ на
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. (Aleksander Alekseev)
Список
Дерево обсуждения
[PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Mark Dilger <mark.dilger@enterprisedb.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Zhihong Yu <zyu@yugabyte.com>
Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. Pavel Borisov <pashkin.elfe@gmail.com>
Hi! I would make two cosmetic changes. 1. I suggest replace description of function bt_report_duplicate() from ``` /* * Prepare and print an error message for unique constrain violation in * a btree index under WARNING level. Also set a flag to report ERROR * at the end of the check. */ ``` to ``` /* * Prepare an error message for unique constrain violation in * a btree index and report ERROR. */ ``` 2. I think will be better to change test 004_verify_nbtree_unique.pl - replace ``` use Test::More tests => 6; ``` to ``` use Test::More; ... done_testing(); ``` (same as in the other three tests). -- With best regards, Dmitry Koval Postgres Professional: http://postgrespro.com
В списке pgsql-hackers по дате отправления
От: David Rowley
Дата: