Re: typos

Поиск
Список
Период
Сортировка
Искать
От
Alvaro Herrera
Тема
Re: typos
Дата
Msg-id
202204131729.g27uwttzzgao@alvherre.pgsql
Ответ на
Re: typos (David Rowley)
Список
Дерево обсуждения
typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos David Rowley <dgrowleyml@gmail.com>
Re: typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos David Rowley <dgrowleyml@gmail.com>
Re: typos Noah Misch <noah@leadboat.com>
Re: typos Masahiko Sawada <sawada.mshk@gmail.com>
Re: typos Amit Kapila <amit.kapila16@gmail.com>
Re: typos Amit Kapila <amit.kapila16@gmail.com>
Re: typos David Rowley <dgrowleyml@gmail.com>
Re: typos Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos David Rowley <dgrowleyml@gmail.com>
Re: typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: typos Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos Justin Pryzby <pryzby@telsasoft.com>
Re: typos Michael Paquier <michael@paquier.xyz>
Re: typos Michael Paquier <michael@paquier.xyz>
Re: typos Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: typos Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: typos Amit Kapila <amit.kapila16@gmail.com>
Re: typos Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: typos Amit Kapila <amit.kapila16@gmail.com>
Re: typos Robert Haas <robertmhaas@gmail.com>
On 2022-Apr-11, David Rowley wrote:

> and also skipped:
> 0016 (unsure if we should change these of pgindent is not touching it)
> 0017 (unsure if we should change these of pgindent is not touching it)

I verified that pgindent will indeed not touch these changes by running
before and after.  (I accepted one comment placement from that run that
touched a neighboring line.)

I think pgindent is right not to modify vertical space very much, since
in many cases it amounts to a subjective decision.  The patch seemed a
(small) improvement, and it seems hard to make too much of a fuss about
such things.  Pushed them as a single commit.

I hadn't noticed that Justin had posted a refreshed patch series, so I
don't know if the new ones match what I pushed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Postgres is bloatware by design: it was built to house
 PhD theses." (Joey Hellerstein, SIGMOD annual conference 2002)


В списке pgsql-hackers по дате отправления
От: Zheng Li
Дата:
От: Justin Pryzby
Дата:
Сообщение: Re: typos
FAQ