Re: [PATCH] Tab completion for VACUUM of partitioned tables

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: [PATCH] Tab completion for VACUUM of partitioned tables
Дата
Msg-id
20200729062119.GF28700@paquier.xyz
Ответ на
Список
Дерево обсуждения
[PATCH] Tab completion for VACUUM of partitioned tables Justin Pryzby <pryzby@telsasoft.com>
Re: [PATCH] Tab completion for VACUUM of partitioned tables Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Re: [PATCH] Tab completion for VACUUM of partitioned tables Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Tab completion for VACUUM of partitioned tables Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Re: [PATCH] Tab completion for VACUUM of partitioned tables Michael Paquier <michael@paquier.xyz>
On Wed, Jul 29, 2020 at 01:27:07PM +0900, Masahiko Sawada wrote:
> Good catch. The patch looks good to me.

While this patch is logically correct.  I think that we should try to
not increase more the number of queries used to scan pg_class
depending on a list of relkinds.  For example, did you notice that
your new Query_for_list_of_vacuumables becomes the same query as
Query_for_list_of_indexables?  You can make your patch more simple.
--
Michael
В списке pgsql-hackers по дате отправления
От: Pavel Stehule
Дата:
От: Hamid Akhtar
Дата:
FAQ