Re: [HACKERS] Log LDAP "diagnostic messages"?

Поиск
Список
Период
Сортировка
Искать
От
Alvaro Herrera
Тема
Re: [HACKERS] Log LDAP "diagnostic messages"?
Дата
Msg-id
20170914141205.eup4kxzlkagtmfac@alvherre.pgsql
Ответ на
Список
Дерево обсуждения
[HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Christoph Berg <myon@debian.org>
Re: [HACKERS] Log LDAP "diagnostic messages"? Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: [HACKERS] Log LDAP "diagnostic messages"? Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: [HACKERS] Log LDAP "diagnostic messages"? Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: [HACKERS] Log LDAP "diagnostic messages"? Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Michael Paquier <michael.paquier@gmail.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Re: [HACKERS] Log LDAP "diagnostic messages"? Thomas Munro <thomas.munro@enterprisedb.com>
I think the ldap_unbind() changes should be in a separate preliminary
patch to be committed separately and backpatched.

The other bits looks fine, with nitpicks

1. please move the new support function to the bottom of the section
dedicated to LDAP, and include a prototype

2. please wrap lines longer than 80 chars, other than error message
strings.  (I don't know why this file plays fast & loose with
project-wide line length rules, but I also see no reason to continue
doing it.)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
В списке pgsql-hackers по дате отправления
От: Thomas Munro
Дата:
От: Simon Riggs
Дата:
FAQ