Re: xmalloc => pg_malloc

On Tuesday, October 02, 2012 06:02:13 PM Tom Lane wrote:
> While looking around to fix the pg_malloc(0) issue, I noticed that
> various other pieces of code such as pg_basebackup have essentially
> identical functions, except they're called xmalloc().  I propose to
> standardize all these things on this set of names:
> 
>     pg_malloc
>     pg_malloc0    (for malloc-and-zero behavior)
>     pg_calloc    (randomly different API for pg_malloc0)
Do we need this?

>     pg_realloc
>     pg_free
>     pg_strdup
I wonder whether the same set of functions should also be available in the 
backend with ereport(EC_OUT_OF_MEMORY, ...) behaviour as well. As noted before 
the are quite some malloc() calls around. Not all of them should be replaced, 
but I think quite some could.

Andres
-- 
Andres Freund        http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services