Re: Yet another (minor) fix in BRIN

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: Yet another (minor) fix in BRIN
Дата
Msg-id
1776964.1604807126@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Yet another (minor) fix in BRIN Tomas Vondra <tomas.vondra@enterprisedb.com>
Re: Yet another (minor) fix in BRIN Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: Yet another (minor) fix in BRIN Tom Lane <tgl@sss.pgh.pa.us>
Re: Yet another (minor) fix in BRIN Michael Paquier <michael@paquier.xyz>
Re: Yet another (minor) fix in BRIN Tomas Vondra <tomas.vondra@enterprisedb.com>
Alvaro Herrera  writes:
> On 2020-Nov-08, Tomas Vondra wrote:
>> While rebasing some of the BRIN patches, I noticed some of the code in
>> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab
>> which moved some of the code from brin_new_memtuple, not removing the
>> shared pieces. In practice this is benign, of course.
>> 
>> Barring objections I'll get the attached fix committed and backpatched.

> LGTM, thanks for noticing.

The weekend before stable-branch releases is probably not the best
time to be pushing "minor" fixes into those branches.  I got my
fingers burned today, and so did Peter.  Don't follow our example ;-)

			regards, tom lane


В списке pgsql-hackers по дате отправления
От: Alvaro Herrera
Дата:
От: Masahiko Sawada
Дата:
FAQ