Re: WIP: executor_hook for pg_stat_statements

On Mon, 2008-06-23 at 15:22 +0900, ITAGAKI Takahiro wrote:
> I'm working on light-weight SQL logging for PostgreSQL.
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00601.php
>
> I divide the SQL logging feature into a core patch and an extension module.
> I hope only the patch is to be applied in the core. The extension module
> would be better to be developed separately from the core.
>
>
> The attached patch (executor_hook.patch) modifies HEAD as follows.
>
> - Add "tag" field (uint32) into PlannedStmt.
> - Add executor_hook to replace ExecutePlan().
> - Move ExecutePlan() to a global function.

The executor_hook.patch is fairly trivial and I see no errors.

The logic of including such a patch is clear. If we have a planner hook
then we should also have an executor hook.

Will you be completing the plugin for use in contrib?

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support