Re: [PATCHES] Full page writes improvement, code update

On Fri, 2007-03-30 at 10:22 +0200, Zeugswetter Andreas ADI SD wrote:
> > Without a switch, because both full page writes and 
> > corresponding logical log is included in WAL, this will 
> > increase WAL size slightly 
> > (maybe about five percent or so).   If everybody is happy 
> > with this, we 
> > don't need a switch.
> 
> Sorry, I still don't understand that. What is the "corresponding logical
> log" ?
> It seems to me, that a full page WAL record has enough info to produce a
> 
> dummy LSN WAL entry. So insead of just cutting the full page wal record
> you 
> could replace it with a LSN WAL entry when archiving the log.
> 
> Then all that is needed is the one flag, no extra space ?

The full page write is required for crash recovery, but that isn't
required during archive recovery because the base backup provides the
safe base. Archive recovery needs the normal xlog record, which in some
cases has been optimised away because the backup block is present, since
the full block already contains the changes.

If you want to remove the backup blocks, you need to put back the
information that was optimised away, otherwise you won't be able to do
the archive recovery correctly. Hence a slight increase in WAL volume to
allow it to be compressed does make sense.

-- 
  Simon Riggs             
  EnterpriseDB   http://www.enterprisedb.com