Re: [HACKERS] Transactions involving multiple postgres foreignservers

I've created a wiki page[1] describing about the design and
functionality of this feature. Also it has some examples of use case,
so this page would be helpful for even testing. Please refer it if
you're interested in testing this feature.

[1] 2PC on FDW
<https://wiki.postgresql.org/wiki/2PC_on_FDW>

Thank you for creating the wiki page.

In the "src/test/regress/pg_regress.c" file
-                * xacts.  (Note: to reduce the probability of unexpected shmmax
-                * failures, don't set max_prepared_transactions any higher than
-                * actually needed by the prepared_xacts regression test.)
+                * xacts. We also set max_fdw_transctions to enable testing of atomic
+                * foreign transactions. (Note: to reduce the probability of unexpected
+                * shmmax failures, don't set max_prepared_transactions or
+                * max_prepared_foreign_transactions any higher than actually needed by the
+                * corresponding regression tests.).

I think we are not setting the "max_fdw_transctions" anywhere.
Is this correct?

In the "src/bin/pg_waldump/rmgrdesc.c" file following header file used two times.
+ #include "access/fdw_xact.h"
I think we need to remove one line.

Regards,
Vinayak Pokale