On 2020-11-27 13:37, Ashutosh Bapat wrote:
> Yeah, I had it like that for a moment, but then you need to duplicate
> the check in get_raw_page() and get_raw_page_fork(). I figured since
> get_raw_page_internal() does all the other argument checking also, it
> seems sensible to put the block range check there too. But it's not a
> big deal either way.
>
>
> FWIW, my 2c. Though I agree with both sides, I
> prefer get_raw_page_internal() accepting BlockNumber, since that's what
> it deals with and not the entire int8.
Patch updated this way. I agree it's better that way.