On Fri, Nov 12, 2021, at 9:41 AM, Daniel Gustafsson wrote:
>
> On Wed, Nov 3, 2021 at 6:21 PM Daniel Gustafsson <
daniel@yesql.se> wrote:
>>
>>
>>> PSA v7.
>>
>> This patch no longer applies on top of HEAD, please submit a rebased version.
>
> Here's a rebased v8 patch. Please review it.
This improves the user experience by increasing the granularity of error
reporting, and maps well with the precedent set in 81d5995b4. I'm marking this
Ready for Committer and will go ahead and apply this unless there are
objections.
Shouldn't we modify errdetail_relkind_not_supported() to include relpersistence
as a 2nd parameter and move those messages to it? I experiment this idea with
the attached patch. The idea is to provide a unique function that reports
accurate detail messages.