On Fri, 11 Mar 2022 at 08:37, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Japin Li <japinli@hotmail.com> writes:
>> Attach a new patch to fix the replica identify case, also add test cases.
>
> Now that we realize we need to de-duplicate, it seems to me we should
> postpone the get_rel_name() calls so that we don't have to do that
> work repeatedly; as attached.
>
Thanks for your review. Agreed.
> Also, while I've not done anything about it here, the proposed test
> cases seem remarkably cavalier about their choices of test table
> names. If you want to use names as generic as "parent" and "child",
> they'd better be temp tables to avoid risk of conflict against other
> concurrent regression tests. But most of alter_table.sql prefers
> to use names starting with "at".
My apologies! How about s/parent/atref/g and s/child/attmp/g ?
Attached v4 patch, please consider this for futher review.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.