Revert "Do execGrouping.c via expression eval machinery."
This reverts commit 773aec7aa98abd38d6d9435913bb8e14e392c274.
There's an unresolved issue in the reverted commit: It only creates
one comparator function, but in for the nodeSubplan.c case we need
more (c.f. FindTupleHashEntry vs LookupTupleHashEntry calls in
nodeSubplan.c).
This isn't too difficult to fix, but it's not entirely trivial
either. The fact that the issue only causes breakage on 32bit systems
shows that the current test coverage isn't that great. To avoid
turning half the buildfarm red till those two issues are addressed,
revert.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2a41507dab0f293ff241fe8ae326065998668af8
Modified Files
--------------
src/backend/executor/execExpr.c | 118 ---------------
src/backend/executor/execExprInterp.c | 29 ----
src/backend/executor/execGrouping.c | 236 +++++++++++++++++++++++-------
src/backend/executor/nodeAgg.c | 143 +++++++-----------
src/backend/executor/nodeGroup.c | 24 +--
src/backend/executor/nodeRecursiveunion.c | 5 +-
src/backend/executor/nodeSetOp.c | 48 +++---
src/backend/executor/nodeSubplan.c | 81 +---------
src/backend/executor/nodeUnique.c | 31 ++--
src/backend/executor/nodeWindowAgg.c | 38 ++---
src/backend/utils/adt/orderedsetaggs.c | 56 +++----
src/include/executor/execExpr.h | 1 -
src/include/executor/executor.h | 28 ++--
src/include/executor/nodeAgg.h | 12 +-
src/include/nodes/execnodes.h | 14 +-
15 files changed, 366 insertions(+), 498 deletions(-)