pgsql: Properly remove ephemeral replication slots after a crash restar

Properly remove ephemeral replication slots after a crash restart.

Ephemeral slots - slots that shouldn't survive database restarts -
weren't properly cleaned up after a immediate/crash restart. They were
ignored in the sense that they weren't restored into memory and thus
didn't cause unwanted resource retention; but they prevented a new
slot with the same name from being created.

Now ephemeral slots are fully removed during startup.

Backpatch to 9.4 where replication slots where added.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/93a028f569232fa498279841cb61ad11c2df5c85

Modified Files
--------------
src/backend/replication/slot.c |   22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)