Re: [PATCH] Combine same ternary types in GIN and TSearch

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: [PATCH] Combine same ternary types in GIN and TSearch
Дата
Msg-id CALT9ZEH9wxsi6b857jbSC1BrwifCycJzEOwr8F4AQ9TjBSy9+g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Combine same ternary types in GIN and TSearch  (Heikki Linnakangas <hlinnaka@iki.fi>)
Список pgsql-hackers
GIN is not just for full-text search, so using TSTernaryValue in
GinScanKeyData is wrong. And it would break existing extensions.

I didn't look much further than that, but I've got a feeling that
combining those is a bad idea. TSTernaryValue is used in text-search
code, even when there is no GIN involved. It's a separate concept, even
though it happens to have the same values.
Probably you are right. But now the code already rely on equivalent value assignments for GinTernaryValue and TSTernaryValue (in checkcondition_gin()). So my idea was to combine them and use them like we use other global data types. We may declare it somewhere outside both gin and search. Or just leave as it is.

Thank you, Heikki for your feedback!

-- 
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Daniel Gustafsson
Дата:
Сообщение: Misc typos
Следующее
От: Andrey Borodin
Дата:
Сообщение: Re: MultiXact\SLRU buffers configuration