There is no need to test for group permissions here, 002_databases.pl already looks after that.
Deleted the test for group permissions in updated patch.
+ # Check for symlink -- needed only on source dir, only allow symlink + # when under pg_tblspc + # (note: this will fall through quietly if file is already gone) + if (-l $srcpath) So you need that but in RecursiveCopy.pm because of init_from_backup when creating the standby, which makes sense when it comes to pg_tblspc. I am wondering about any side effects though, and if it would make sense to just remove the restriction for symlinks in _copypath_recurse(). -- Michael
Checking the RecursiveCopy::copypath being called, only _backup_fs and init_from_backup called it.
After runing cmd make -C src/bin check in updated patch, seeing no failure.