Re: Improvements and additions to COPY progress reporting

Поиск
Список
Период
Сортировка
От 0010203112132233
Тема Re: Improvements and additions to COPY progress reporting
Дата
Msg-id CAEze2Wjd1r9EhynUev9E5jeeGqzYhDS29bpb-KE0drRC8Ax7DQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Improvements and additions to COPY progress reporting  (Josef Šimánek <josef.simanek@gmail.com>)
Список pgsql-hackers
On Tue, 9 Feb 2021 at 09:32, Josef Šimánek <josef.simanek@gmail.com> wrote:
>
> po 8. 2. 2021 v 19:35 odesílatel Matthias van de Meent
> <boekewurm+postgres@gmail.com> napsal:
> > Lastly, 0005 adds 'io_target' to the reported information, that is,
> > FILE, PROGRAM, STDIO or CALLBACK. Although this can relatively easily
> > be determined based on the commands in pg_stat_activity, it is
> > reasonably something that a user would want to query on, as the
> > origin/target of COPY has security and performance implications,
> > whereas other options (e.g. format) are less interesting for clients
> > that are not executing that specific COPY command.
>
> I took a little deeper look and I'm not sure if I understand FILE and
> STDIO. I have finally tried to finalize some initial regress testing
> of COPY command progress using triggers. I have attached the initial
> patch  applicable to your changes. As you can see COPY FROM STDIN is
> reported as FILE. That's probably expected, but it is a little
> confusing for me since STDIN and STDIO sound similar. What is the
> purpose of STDIO? When is the COPY command reported with io_target of
> STDIO?

I checked for the type of the copy_src before it was correctly set,
therefore only reporting FILE type, but this will be fixed shortly in
v3.

Matthias



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Clean up code
Следующее
От: Josef Šimánek
Дата:
Сообщение: Re: Improvements and additions to COPY progress reporting