Re: Remove an obsolete comment in snapbuild.c

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: Remove an obsolete comment in snapbuild.c
Дата
Msg-id CAA4eK1K0Kned5xN4FEz1+PjYeFwPwhS4efxq9SU-qhj5L8=U4w@mail.gmail.com
обсуждение исходный текст
Ответ на Remove an obsolete comment in snapbuild.c  (Masahiko Sawada <sawada.mshk@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Mon, Oct 4, 2021 at 1:24 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Hi all,
>
> While reading the code I realized that the following comment of
> SnapBuildOnDick is obsolete:
>
> /*
>  * We store current state of struct SnapBuild on disk in the following manner:
>  *
>  * struct SnapBuildOnDisk;
>  * TransactionId * running.xcnt_space;
>  * TransactionId * committed.xcnt; (*not xcnt_space*)
>  *
>  */
> typedef struct SnapBuildOnDisk
>
> Since SnapBuild has no longer "running" struct, it should be removed.
> Please find an attached patch.
>

LGTM. I'll push this tomorrow unless someone thinks otherwise.

-- 
With Regards,
Amit Kapila.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Incorrect snapshots while promoting hot standby node when 2PC is used
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: replace InvalidXid(a macro that doesn't exist) with InvalidTransactionId(a macro that exists) in code comments