Re: Patch: New field in frmMain statusbar
От | Dave Page |
---|---|
Тема | Re: Patch: New field in frmMain statusbar |
Дата | |
Msg-id | CA+OCxox1Ky8VXLEzLNoFj77_V5u=hbjnnvffELk1dicazm=s2A@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Patch: New field in frmMain statusbar (Magnus Hagander <magnus@hagander.net>) |
Ответы |
Re: Patch: New field in frmMain statusbar
(Magnus Hagander <magnus@hagander.net>)
|
Список | pgadmin-hackers |
On Mon, Sep 14, 2015 at 5:11 PM, Magnus Hagander <magnus@hagander.net> wrote: > The part that changed is just the one that added db1 and db2, right? It's the server display name *and* the database name, so to give a (redacted) example from my machine, I would have: aws-ap-southeast-1b.xxxxxxxxxxxxxxxx.com (aws-ap-southeast-1b. xxxxxxxxxxxxxxxx.com:5432):postgres Which as you can see is quite long. > If so I definitely don't think it's a problem with too much info,and think > this patch is good. (I haven't reviewed the code) > > //Magnus > > > On Mon, Sep 14, 2015 at 3:34 PM, Adam Scott <adam.c.scott@gmail.com> wrote: >> >> Hi, >> >> thank you for your time to consider this patch. >> >> Here's a few screenshots on my Windows 7 desktop. Let me know if you want >> to see anything else. >> A few observations: >> >> >> >> >> >> >> On Mon, Sep 14, 2015 at 4:43 AM, Magnus Hagander <magnus@hagander.net> >> wrote: >>> >>> I don't have a working pgadmin env at the moment - any chance someone who >>> has built it could show a screenshot? >>> >>> I've certainly had customers complain about pgadmin in the case of many >>> databases, though it's generally been on account of performance, and not >>> something like this. >>> >>> //Magnus >>> >>> >>> On Mon, Sep 14, 2015 at 10:57 AM, Dave Page <dpage@pgadmin.org> wrote: >>>> >>>> Thanks Adam. >>>> >>>> What do others feel about this proposed patch? I can see how it might >>>> be useful, however I'm also concerned about overloading the UI with >>>> more info - and in over a decade I don't recall anyone ever asking for >>>> this feature or complaining of the issue Adam describes (though, it is >>>> clearly feasible). >>>> >>>> On Sun, Sep 13, 2015 at 4:19 PM, Adam Scott <adam.c.scott@gmail.com> >>>> wrote: >>>> > Hi, >>>> > >>>> > please consider this patch to frmMain. >>>> > >>>> > Situation: When a user has a large number of databases and >>>> > connections, >>>> > when they select a table or other object in the Object browser tree, >>>> > they >>>> > can lose track of which connection and database the object belongs >>>> > too. >>>> > This makes it really easy for the user to make a mistake and drop an >>>> > object >>>> > on the wrong connection (such as on a Production server instead of a >>>> > Development server). Also as a user is browsing multiple databases >>>> > and >>>> > connections they can lose track of which object they are working on. >>>> > >>>> > Solution: This patch adds a new field in the status bar of the main >>>> > window >>>> > (frmMain), between the two other fields, keeping them the same. If >>>> > there's >>>> > a currently selected object the field will display it's connection and >>>> > database. If there's no currently selected object, it will be blank. >>>> > >>>> > Here's the danger, if we display the wrong connection and database, >>>> > the user >>>> > could drop the wrong object. So it's imperative this never has a bug. >>>> > This >>>> > code change is so small with so little dependencies, it relies on >>>> > already >>>> > used code for such a long time that if it had a bug, then there are >>>> > other >>>> > bigger bugs in the code that would have already shown up. >>>> > >>>> > Regards, >>>> > Adam C. Scott >>>> > >>>> > patch generated using Tortoise Git Create Patch Serial >>>> > >>>> > >>>> > >>>> > -- >>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> > To make changes to your subscription: >>>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>>> > >>>> >>>> > > -- > Magnus Hagander > Me: http://www.hagander.net/ > Work: http://www.redpill-linpro.com/ -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
В списке pgadmin-hackers по дате отправления: