Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
От | Arne Roland |
---|---|
Тема | Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path |
Дата | |
Msg-id | 920f0b3b5761410ab6833787211af250@index.de обсуждение исходный текст |
Ответ на | Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path (Tomas Vondra <tomas.vondra@enterprisedb.com>) |
Ответы |
Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
(Arne Roland <A.Roland@index.de>)
|
Список | pgsql-hackers |
Hi,
thanks for the quick reply!
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
Sent: Thursday, June 3, 2021 20:11
To: Arne Roland; pgsql-hackers
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
> I haven't tested the parallel case, but I think we should sort out (3)
> get_cheapest_fractional_path_for_pathkeys as mentioned above.
>
Not sure what you refer to by "above" - it's probably better to reply
in-line to existing message, which makes it much cleared.
I was referring to one message above. I thought the thread was still short enough. Apparently to much time has passed. Sorry, I hope this mail is better. I was referring to my post from April:
From: Arne Roland
Sent: Monday, April 26, 2021 13:00
To: Tomas Vondra; pgsql-hackers
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
>3) Not sure if get_cheapest_fractional_path_for_pathkeys should worry
Sent: Thursday, June 3, 2021 22:50
To: Tomas Vondra
Cc: Arne Roland; pgsql-hackers
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
src/backend/optimizer/path/pathkeys.c:get_cheapest_fractional_path_for_pathkeys(List *paths,
src/backend/optimizer/plan/planagg.c: get_cheapest_fractional_path_for_pathkeys(final_rel->pathlist,
Sent: Thursday, June 3, 2021 22:57
To: Zhihong Yu
Cc: Arne Roland; pgsql-hackers
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
Actually, there are two comments
/* XXX maybe we should have startup_new_fractional? */
in the patch I posted - I completely forgot about that. But I think
that's a typo, I think - it should be
/* XXX maybe we should have startup_neq_fractional? */
and the new flag would work similarly to startup_neq_total, i.e. it's
pointless to add paths where startup == fractional cost.
At least I think that was the idea when I wrote the patch, it way too
long ago.
Sorry, I almost forgot about this myself. I only got reminded upon seeing that again with different queries/tables.
В списке pgsql-hackers по дате отправления:
Предыдущее
От: Michael PaquierДата:
Сообщение: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Следующее
От: Jeff DavisДата:
Сообщение: Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions