Re: Remove a unused argument from qual_is_pushdown_safe

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Remove a unused argument from qual_is_pushdown_safe
Дата
Msg-id 8CA0AAC5-688F-4189-BDA0-B684BBDC29BA@yesql.se
обсуждение исходный текст
Ответ на Re: Remove a unused argument from qual_is_pushdown_safe  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
> On 28 Nov 2022, at 15:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> My viewpoint is that this change is misguided.  Even if the current
> coding of qual_is_pushdown_safe doesn't happen to reference the
> subquery, it might need to in future.

If I understand the code correctly the variable has some value in terms of
"documenting the code" (for lack of better terminology), and I would assume
virtually every modern compiler to figure out it's not needed.

--
Daniel Gustafsson        https://vmware.com/




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Remove a unused argument from qual_is_pushdown_safe
Следующее
От: Simon Riggs
Дата:
Сообщение: Bug in wait time when waiting on nested subtransaction