Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22

On 07/03/2015 01:47 AM, Marco Atzeri wrote:
> On 7/2/2015 5:16 PM, Dave Page wrote:
>> The PostgreSQL Global Development Group announces that the alpha
>> release of PostgreSQL 9.5, the latest version of the world's leading
>> open source database, is available today.  This release contains
>> previews of all of the features which will be available in the final
>> release of version 9.5, although some details will change before then.
>> Please download, test, and report what you find.
>>
>> Help Test for Bugs
>> ------------------
>
>
>
> building on cygwin and
>
> $ perl --version
>
> This is perl 5, version 22, subversion 0 (v5.22.0) built for 
> cygwin-thread-multi-64int
>
> build fail here, anyone seeing the same on other platforms ?
>
> make -C hstore_plperl all
> make[1]: Entering directory 
> '/cygdrive/e/cyg_pub/devel/postgresql/prova/postgres 
> ql-9.5alpha1-1.i686/build/contrib/hstore_plperl'
> gcc -Wall -Wmissing-prototypes -Wpointer-arith 
> -Wdeclaration-after-statement -We ndif-labels 
> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -f 
>                        wrapv -fexcess-precision=standard -ggdb -O2 
> -pipe -Wimplicit-function-declaratio                           n 
> -I/pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/src/postgresql-9.5a 
>                           lpha1/src/pl/plperl 
> -I/pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/sr 
>                c/postgresql-9.5alpha1/contrib/hstore -I. 
> -I/pub/devel/postgresql/prova/postgres 
> ql-9.5alpha1-1.i686/src/postgresql-9.5alpha1/contrib/hstore_plperl 
> -I../../src/i                           nclude 
> -I/pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/src/postgresql- 
>                          9.5alpha1/src/include 
> -I/usr/lib/perl5/5.22/i686-cygwin-threads-64int/CORE  -c             
> -o hstore_plperl.o 
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/src/p 
> ostgresql-9.5alpha1/contrib/hstore_plperl/hstore_plperl.c
> In file included from 
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/sr
> c/postgresql-9.5alpha1/contrib/hstore_plperl/hstore_plperl.c:6:0:
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/src/postgresql-9.5alpha1 
>                           /contrib/hstore/hstore.h:79:0: warning: 
> "HS_KEY" redefined
>  #define HS_KEY(arr_,str_,i_) ((str_) + HSE_OFF((arr_)[2*(i_)]))
>  ^
> In file included from 
> /usr/lib/perl5/5.22/i686-cygwin-threads-64int/CORE/perl.h: 
>              3730:0,
>                  from 
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/sr 
>              c/postgresql-9.5alpha1/src/pl/plperl/plperl.h:48,
>                  from 
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/sr
> c/postgresql-9.5alpha1/contrib/hstore_plperl/hstore_plperl.c:4:
> /usr/lib/perl5/5.22/i686-cygwin-threads-64int/CORE/util.h:221:0: note: 
> this is t                           he location of the previous 
> definition
>  #  define HS_KEY(setxsubfn, popmark, apiver, xsver) \
>  ^
> gcc -Wall -Wmissing-prototypes -Wpointer-arith 
> -Wdeclaration-after-statement -We ndif-labels 
> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -f 
>                        wrapv -fexcess-precision=standard -ggdb -O2 
> -pipe -Wimplicit-function-declaratio                           n 
> -shared -o hstore_plperl.dll -Wl,--out-implib=libhstore_plperl.a 
> hstore_plpe                           rl.o  -L../../src/port 
> -L../../src/common -Wl,-no-undefined -Wl,--allow-multiple             
> -definition -Wl,--enable-auto-import  -L/usr/local/lib 
> -Wl,--as-needed   -L../..                           /src/backend 
> -lpostgres -lpgcommon -lpgport -lintl -lssl -lcrypto -lz -lreadline 
>                        -lcrypt -lldap
> hstore_plperl.o: In function `hstore_to_plperl':
> /pub/devel/postgresql/prova/postgresql-9.5alpha1-1.i686/src/postgresql-9.5alpha1 
> /contrib/hstore_plperl/hstore_plperl.c:16: undefined reference to 
> `hstoreUpgrade                           '
>
>


That #define clash is annoying, We should probably #undefine HS_KEY if 
it's defined before including hstore.h.

cheers

andrew