Re: [RFC] overflow checks optimized away
От
Heikki Linnakangas
Тема
Re: [RFC] overflow checks optimized away
Дата
Msg-id
5298FAB0.5010203@vmware.com
Ответ на
Re: [RFC] overflow checks optimized away (Greg Stark)
Список
Дерево обсуждения
[RFC] overflow checks optimized away Xi Wang <xi.wang@gmail.com>
Re: [RFC] overflow checks optimized away Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [RFC] overflow checks optimized away Robert Haas <robertmhaas@gmail.com>
Re: [RFC] overflow checks optimized away Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [RFC] overflow checks optimized away Bruce Momjian <bruce@momjian.us>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Robert Haas <robertmhaas@gmail.com>
Re: [RFC] overflow checks optimized away Bruce Momjian <bruce@momjian.us>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Bruce Momjian <bruce@momjian.us>
Re: [RFC] overflow checks optimized away Bruce Momjian <bruce@momjian.us>
Re: [RFC] overflow checks optimized away Michael Paquier <michael.paquier@gmail.com>
Re: [RFC] overflow checks optimized away Michael Paquier <michael.paquier@gmail.com>
Re: [RFC] overflow checks optimized away Michael Paquier <michael.paquier@gmail.com>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Tom Lane <tgl@sss.pgh.pa.us>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Tom Lane <tgl@sss.pgh.pa.us>
Re: [RFC] overflow checks optimized away Andres Freund <andres@anarazel.de>
Re: [RFC] overflow checks optimized away Michael Paquier <michael.paquier@gmail.com>
Re: [RFC] overflow checks optimized away Tom Lane <tgl@sss.pgh.pa.us>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Greg Stark <stark@mit.edu>
Re: [RFC] overflow checks optimized away Tom Lane <tgl@sss.pgh.pa.us>
Re: [RFC] overflow checks optimized away Heikki Linnakangas <hlinnakangas@vmware.com>
Re: [RFC] overflow checks optimized away Heikki Linnakangas <hlinnakangas@vmware.com>
[PATCH 0/3] Work around icc miscompilation Xi Wang <xi.wang@gmail.com>
[PATCH 1/3] Fix x + y < x overflow checks Xi Wang <xi.wang@gmail.com>
Re: [PATCH 1/3] Fix x + y < x overflow checks Robert Haas <robertmhaas@gmail.com>
Re: [PATCH 1/3] Fix x + y < x overflow checks Claudio Freire <klaussfreire@gmail.com>
[PATCH 2/3] Fix x + 1 < x overflow checks Xi Wang <xi.wang@gmail.com>
[PATCH 3/3] Fix overflow checking in repeat() Xi Wang <xi.wang@gmail.com>
Re: [PATCH 0/3] Work around icc miscompilation Heikki Linnakangas <hlinnakangas@vmware.com>
Re: [PATCH 0/3] Work around icc miscompilation Xi Wang <xi.wang@gmail.com>
Re: [PATCH 0/3] Work around icc miscompilation Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH 0/3] Work around icc miscompilation Xi Wang <xi.wang@gmail.com>
Re: [PATCH 0/3] Work around icc miscompilation Noah Misch <noah@leadboat.com>
Re: [PATCH 0/3] Work around icc miscompilation Greg Stark <stark@mit.edu>
Re: [PATCH 0/3] Work around icc miscompilation Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH 0/3] Work around icc miscompilation Xi Wang <xi.wang@gmail.com>
Re: [PATCH 0/3] Work around icc miscompilation Greg Stark <stark@mit.edu>
On 11/29/2013 10:06 PM, Greg Stark wrote: > On Fri, Nov 29, 2013 at 7:39 PM, Greg Stark wrote: >> >> Just as an update I did get gcc to do the wrong thing on purpose. The >> only overflow check that the regression tests find missing is the one >> for int8abs() ie: > > > Also, one of the places GCC warns about optimizing away an overflow > check (with -fno-wrapv) is inside the localtime.c file from the tz > library. I fixed it in my patch but in fact I checked and it's already > fixed upstream so I'm wondering whether you expect to merge in an > updated tz library? Is there anything surprising about the process or > do you just copy in the files? Would you be happy for someone else to > do it? IIRC some files can be copied directly, but not all. Might be easiest to generate a diff between the last version in PostgreSQL and the latest upstream version, and apply that. - Heikki
В списке pgsql-hackers по дате отправления