On 24.04.24 01:43, Thomas Munro wrote:
> Rebased over ca89db5f.
These patches look fine to me. The new cut-off makes sense, and it does
save quite a bit of code. We do need to get the Cirrus CI Debian images
updated first, as you had already written.
As part of this patch, you also sneak in support for LLVM 18
(llvm-config-18, clang-18 in configure). Should this be a separate patch?
And as I'm looking up how this was previously handled, I notice that
this list of clang-NN versions was last updated equally sneakily as part
of your patch to trim off LLVM <10 (820b5af73dc). I wonder if the
original intention of that configure code was that maintaining the
versioned list above clang-7/llvm-config-7 was not needed, because the
unversioning programs could be used, or maybe because pkg-config could
be used. It would be nice if we could get rid of having to update that.