Re: MMAP Buffers
От
Greg Smith
Тема
Re: MMAP Buffers
Дата
Msg-id
4DAA23F9.8030504@2ndquadrant.com
Ответ на
Re: MMAP Buffers (Radosław Smogura)
Список
Дерево обсуждения
MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Peter Eisentraut <peter_e@gmx.net>
Re: MMAP Buffers Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: MMAP Buffers Joshua Berkus <josh@agliodbs.com>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Joshua Berkus <josh@agliodbs.com>
Re: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
Re: MMAP Buffers Joshua Berkus <josh@agliodbs.com>
Re: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
The big picture for patch submission (was Re: MMAP Buffers) Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Joshua Berkus <josh@agliodbs.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Christopher Browne <cbbrowne@gmail.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: Formatting Curmudgeons WAS: MMAP Buffers "Joshua D. Drake" <jd@commandprompt.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Alvaro Herrera <alvherre@commandprompt.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Jeff Janes <jeff.janes@gmail.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Bruce Momjian <bruce@momjian.us>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Bruce Momjian <bruce@momjian.us>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Andrew Dunstan <andrew@dunslane.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Magnus Hagander <magnus@hagander.net>
Re: Formatting Curmudgeons WAS: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
Re: Formatting Curmudgeons WAS: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
Re: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: MMAP Buffers Greg Stark <gsstark@mit.edu>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Tom Lane <tgl@sss.pgh.pa.us>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Andres Freund <andres@anarazel.de>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Andres Freund <andres@anarazel.de>
Re: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Robert Haas <robertmhaas@gmail.com>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Radosław Smogura <rsmogura@softperience.eu>
Re: MMAP Buffers Marko Kreen <markokr@gmail.com>
Re: MMAP Buffers Greg Smith <greg@2ndquadrant.com>
Re: MMAP Buffers Marko Kreen <markokr@gmail.com>
Radosław Smogura wrote: > Yes, but, hmm... in Netbeans I had really long gaps (probably 8 > spaces, from tabs), so deeper "ifs", comments at the and of variables, > went of out my screen. I really wanted to not format this, but > sometimes I needed. The guide at http://www.open-source-editor.com/editors/how-to-make-netbeans-use-tabs-for-indention.html seems to cover how to fix this in Netbeans. You want it to look like that screen shot: 4 spaces per indent with matching tab size of 4, and "Expand Tabs to Spaces" unchecked. Generally, if you look at the diff you've created, and your new code doesn't line up right with what's already there, that means the tab/space setup isn't quite right when you were editing. Reading the diff is useful for catching all sorts of other issues, too, so it's just generally a good practice. As Peter already mentioned, the big problem here is that you checked in a modified configure file. I also note that you use C++ style "//" comments, which aren't allowed under the coding guidelines--even though they work fine on many common platforms. -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
В списке pgsql-hackers по дате отправления