Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

Tom Lane wrote:
> Heikki Linnakangas  writes:
>> Here's a patch taking that approach, and I think it's better than the
>> previous  one. I was afraid we would lose robustness if we have to set
>> the shared state as "out of recovery" before requesting the checkpoint,
>> but we can use the same trick we were using in startup process and set
>> LocalRecoveryInProgress=false before setting the shared variable. I
>> introduced a new CHECKPOINT_IS_STARTUP flag,
> 
> This isn't a "startup" checkpoint, it's an "end of recovery" checkpoint,
> because we don't do it during normal startup.  Not sure about an equally
> concise name based on that, but I don't like IS_STARTUP.

Ok, END_OF_RECOVERY works for me.

-- 
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com