Re: Clean up ancient test style

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Clean up ancient test style
Дата
Msg-id 4165763.1607707375@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Clean up ancient test style  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Список pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Many older tests where written in a style like
>      SELECT '' AS two, i.* FROM INT2_TBL ...

> where the first column indicated the number of expected result rows.
> This has gotten increasingly out of date, as the test data fixtures
> have expanded, so a lot of these don't match anymore and are misleading. 
>   Moreover, this style isn't really necessary, since the psql output 
> already shows the number of result rows.  (Perhaps this was different at 
> some point?)

> I'm proposing to clean all this up by removing all those extra columns.

+1 for concept ... I didn't bother to check the patch in detail.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Rethinking plpgsql's assignment implementation
Следующее
От: Robert Haas
Дата:
Сообщение: Re: pg_basebackup test coverage