Convert node test compile-time settings into run-time parameters

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Convert node test compile-time settings into run-time parameters
Дата
Msg-id 30747bd8-f51e-4e0c-a310-a6e2c37ec8aa@eisentraut.org
обсуждение исходный текст
Ответы Re: Convert node test compile-time settings into run-time parameters  (Ranier Vilela <ranier.vf@gmail.com>)
Re: Convert node test compile-time settings into run-time parameters  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Convert node test compile-time settings into run-time parameters  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
This patch converts the compile-time settings

     COPY_PARSE_PLAN_TREES
     WRITE_READ_PARSE_PLAN_TREES
     RAW_EXPRESSION_COVERAGE_TEST

into run-time parameters

     debug_copy_parse_plan_trees
     debug_write_read_parse_plan_trees
     debug_raw_expression_coverage_test

They can be activated for tests using PG_TEST_INITDB_EXTRA_OPTS.

The effect is the same, but now you don't need to recompile in order to 
use these checks.

The compile-time symbols are kept for build farm compatibility, but they 
now just determine the default value of the run-time settings.

Possible concerns:

- Performance?  Looking for example at pg_parse_query() and its 
siblings, they also check for other debugging settings like 
log_parser_stats in the main code path, so it doesn't seem to be a concern.

- Access control?  I have these settings as PGC_USERSET for now. Maybe 
they should be PGC_SUSET?

Another thought:  Do we really need three separate settings?

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Pavel Stehule
Дата:
Сообщение: Re: Schema variables - new implementation for Postgres 15
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: State of pg_createsubscriber