On Wed, Apr 07, 2021 at 05:45:16PM +0530, Amit Kapila wrote:
> On Wed, Apr 7, 2021 at 1:11 PM Ajin Cherian <itsajin@gmail.com> wrote:
> >
> > Found that some documentation hasn't been updated for the changes made as part of
> > streaming large in-progress transactions. Attached a patch that adds the missing changes. Let me know if anything
moreneeds to be added or any comments on this change.
> >
>
> Thanks, this mostly looks good to me. I have slightly modified it.
> See, what do you think of the attached?
+ Protocol version. Currently versions <literal>1</literal> and
+ <literal>2</literal> are supported. The version <literal>2</literal>
+ is supported only for server versions 14 and above, and is used to allow
+ streaming of large in-progress transactions.
The diff briefly confused me, since this is in protocol.sgml, and since the
libpq protocol version is 1/2/3, with 2 being removed in v14 (3174d69fb).
I suggest to say "replication protocol version 2".
I realize that the headings make this more clear when reading the .html, so
maybe there's no issue.
--
Justin