On 2017-03-01 14:40:26 -0300, Alvaro Herrera wrote:
> Josh Soref wrote:
>
> > One thing that would be helpful is if someone could comment on:
> > https://github.com/jsoref/postgres/commit/9050882d601134ea1ba26f77ce5f1aaed75418de
> > -#undef SH_ITERTOR
> > +#undef SH_ITERATOR
> >
> > It's unclear to me what that line is/was doing. It's possible that it
> > could be removed entirely instead of having its spelling changed.
> > If the line is trying to guard against a previous version of the code,
> > which is no longer active, then it deserves a comment.
>
> AFAICS this is a bug. This file can potentially be included several
> times by the same C source, and it defines SH_ITERATOR every time. The
> second time it needs to be #undef'ed prior, which this line is supposed
> to do but fails because of the typo.
Indeed. Fixed, thanks for noticing.
Andres