Re: pgsql: Fix bug leading to restoring unlogged relations from empty files

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Дата
Msg-id 20151213175725.GY14789@awork2.anarazel.de
обсуждение исходный текст
Ответ на Re: pgsql: Fix bug leading to restoring unlogged relations from empty files  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-committers
Дерево обсуждения 
On 2015-12-13 12:37:18 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Fix bug leading to restoring unlogged relations from empty files.
>
> Coverity thinks, quite correctly AFAICS, that this line you wrote in
> FlushOneBuffer() is useless:
>
>     LWLockHeldByMe(bufHdr->content_lock);
>
> Perhaps you meant
>
>     Assert(LWLockHeldByMe(bufHdr->content_lock));
>

Yes :(. I'll be back at my computer in a couple hours and will fix it
then or tomorrow morning.

Andres

В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Code and docs review for multiple -c and -f options in psql.