Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Prior to PG 8.2, this was necessary to put the comment on the database,
> > but now that we have the shared comment/description table
> > pg_shdescription, this is not necessary.
>
> > Do we need createdb to be able to create databases for pre-8.2 clusters?
> > If not, the attached patch fixes the double-prompting.
>
> Well, if you're only going to change this in HEAD, that might be an
> acceptable limitation, but if you intend to back-patch I think not.
> Older versions of createdb are probably significantly more likely to
> be used with even-older servers.
This code has been that way since pre-8.2 so I see no need to backpatch;
this is the first such complaint I have seen.
> Seems like it wouldn't be that hard to test the server version and only
> reconnect if it's pre-8.2.
I am not excited about adding more code for this so I am thinking
head-only.
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +