Re: 8.0: Absolute path required for INITDB?

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: 8.0: Absolute path required for INITDB?
Дата
Msg-id 200408160342.i7G3gcD09155@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: 8.0: Absolute path required for INITDB?  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-bugs
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > What was the resolution of this?  Can we make relative -L work or do we
> > add error checks for relative -L paths?
>
> We fixed the problem that was requiring Josh to use -L.  I think -L is a
> wizard's switch and need not be user-friendly, so I feel no need to do
> either of the above.

Yea, but it is so easy to fix, so why not do it.  Patch attached.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/bin/initdb/initdb.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/initdb/initdb.c,v
retrieving revision 1.49
diff -c -c -r1.49 initdb.c
*** src/bin/initdb/initdb.c    11 Aug 2004 23:28:54 -0000    1.49
--- src/bin/initdb/initdb.c    16 Aug 2004 03:22:38 -0000
***************
*** 2234,2240 ****
          share_path = xmalloc(MAXPGPATH);
          get_share_path(backend_exec, share_path);
      }
!
      canonicalize_path(share_path);

      if ((short_version = get_short_version()) == NULL)
--- 2234,2245 ----
          share_path = xmalloc(MAXPGPATH);
          get_share_path(backend_exec, share_path);
      }
!     else if (!is_absolute_path(share_path))
!     {
!         fprintf(stderr, _("%s: input file location must be an absolute path\n"), progname);
!         exit(1);
!     }
!
      canonicalize_path(share_path);

      if ((short_version = get_short_version()) == NULL)

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: 8.0: Absolute path required for INITDB?
Следующее
От: Devrim GUNDUZ
Дата:
Сообщение: Re: Turkish downcasting in PL/pgSQL