Tom Lane wrote:
> Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > + /* Flag to we need to initialize client encoding info */
> > + static bool need_to_init_client_encoding = -1;
>
> Surely that should be int, not bool.
>
> > ! if (!PQsendQuery(conn, "begin; select pg_client_encoding(); commit"))
>
> Doesn't this break compatibility with pre-7.2 databases? AFAICT that
> function was introduced in 7.2.
I haven't seen this patch applied. If this is the best way to fix the
bug, we may as well break libpq for pre-7.2 clients.
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square,
Pennsylvania19073