Andres Freund <andres@2ndquadrant.com> writes:
> On 2015-02-16 21:34:57 -0500, Tom Lane wrote:
>> Also, if we want to insist that these fields be accessed
>> through heap_getattr, I'd be inclined to put them inside the "#ifdef
>> CATALOG_VARLEN" to enforce that.
> That we definitely should do. It's imo just a small bug that it was
> omitted here. I'll fix it, but not backpatch unless you prefer?
Agreed, that's really independent of FLEXIBLE_ARRAY_MEMBER, so fix
it as its own patch. I also agree that back-patching is probably
not appropriate.
regards, tom lane